18a926e836
Previously I eschewed the use of CMAKE_MSVC_RUNTIME_LIBRARY in favour of setting the flags using target_compile_options so that they would propagate to consumers. However, it has been raised that a dependency( independent to godot-cpp ) that doesn't set any runtime flags, which relies purely on the CMAKE_MSVC_RUNTIME_LIBRARY variable will very likely not have the correct msvc runtime flags set. Where MSVC documentation states "All modules passed to a given invocation of the linker must have been compiled with the same runtime library compiler option (/MD, /MT, /LD)." It was also mentioned that message type WARNING is not ideal for notifying consumers. So I have updated the cmake code to use CMAKE_MSVC_RUNTIME_LIBRARY over target-compile_options. And set it as a CACHE STRING variable so that it can be overridden if desired. We still message consumers, but as a NOTICE. |
||
|---|---|---|
| .. | ||
| android.cmake | ||
| common_compiler_flags.cmake | ||
| emsdkHack.cmake | ||
| godotcpp.cmake | ||
| ios.cmake | ||
| linux.cmake | ||
| macos.cmake | ||
| python_callouts.cmake | ||
| web.cmake | ||
| windows.cmake | ||