From a926b96103e2c9e2aa3e6941e804a102b37b4cf5 Mon Sep 17 00:00:00 2001 From: Martin Capitanio Date: Thu, 19 Oct 2023 08:45:03 +0200 Subject: [PATCH] clang: Add CallableCustomMethodPointerBase virtual destructor Fixes #1272 + clang++ (debian v16/v17) warning: destructor called on 'godot::CallableCustomMethodPointerBase' that is abstract but has non-virtual destructor [-Wdelete-abstract-non-virtual-dtor] --- include/godot_cpp/variant/callable_method_pointer.hpp | 1 + 1 file changed, 1 insertion(+) diff --git a/include/godot_cpp/variant/callable_method_pointer.hpp b/include/godot_cpp/variant/callable_method_pointer.hpp index bd31ea1..d83bcba 100644 --- a/include/godot_cpp/variant/callable_method_pointer.hpp +++ b/include/godot_cpp/variant/callable_method_pointer.hpp @@ -40,6 +40,7 @@ class CallableCustomMethodPointerBase { public: virtual Object *get_object() const = 0; virtual void call(const Variant **p_arguments, int p_argcount, Variant &r_return_value, GDExtensionCallError &r_call_error) const = 0; + virtual ~CallableCustomMethodPointerBase() {} }; namespace internal {