Sara.Sync
/
godot-cpp
mirror of https://github.com/godotengine/godot-cpp
0
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix Vector's Bounce Reflect 

Fixes Vector 2 and 3 bounce and reflect methods to match gdscript

Co-Authored-By: Bruno Campos <brunocu@msn.com>

Move calculation to reflect

fix commit

squash

fix style
pull/371/head
NHodgesVFX 2020-02-04 16:33:43 -05:00
parent aba8766618
commit a2e6f7a5ef
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/core/Vector2.hpp
View File

@ -180,8 +180,8 @@ struct Vector2 {
return -reflect(p_normal); return -reflect(p_normal);
} }
inline Vector2 reflect(const Vector2 &p_vec) const { inline Vector2 reflect(const Vector2 &p_normal) const {
return p_vec - *this * this->dot(p_vec) * 2.0; return -(*this -p_normal * this->dot(p_normal) * 2.0);
} }
inline real_t angle() const { inline real_t angle() const {

4
include/core/Vector3.hpp
View File

@ -238,8 +238,8 @@ struct Vector3 {
return v; return v;
} }
inline Vector3 reflect(const Vector3 &by) const { inline Vector3 reflect(const Vector3 &p_normal) const {
return by - *this * this->dot(by) * 2.f; return -(*this - p_normal * this->dot(p_normal) * 2.f);
} }
inline Vector3 rotated(const Vector3 &axis, const real_t phi) const { inline Vector3 rotated(const Vector3 &axis, const real_t phi) const {