Fix #1059: Linking for mingw/x86_64 on MSYS2 fails, w/ ar execution speed up

tools/my_spawn.py

@@ -11,34 +11,39 @@ def configure(env):
     import subprocess
 
     def mySubProcess(cmdline, env):
-        # print("SPAWNED: " + cmdline)
+        # print(cmdline)
-        proc = subprocess.run(
+        proc = subprocess.run(args=cmdline, shell=True, env=env)
-            args=cmdline,
-            shell=True,
-            env=env,
-        )
         rv = proc.returncode
         if rv:
             print("=====")
-            print(rv, "(", hex(rv), ")")
+            print("subprocess.run().returncode=", rv, "(", hex(rv), ")")
+            print("len(cmdline)=", len(cmdline))
             print("=====")
         return rv
 
     def mySpawn(sh, escape, cmd, args, env):
-
+        if len(args) > 3 and cmd.endswith("ar"):
-        newargs = " ".join(args[1:])
+            # print("Long ar command is split.\nargc=", len(args))
-        cmdline = cmd + " " + newargs
+            lead = len(" ".join(args[0:3]))
-
+            begin = 3
-        rv = 0
+            length = lead + 1 + len(args[begin])
-        if len(cmdline) > 32000 and cmd.endswith("ar"):
+            rv = 0
-            cmdline = cmd + " " + args[1] + " " + args[2] + " "
+            for i in range(4, len(args)):
-            for i in range(3, len(args)):
+                length += 1 + len(args[i])
-                rv = mySubProcess(cmdline + args[i], env)
+                if length >= 8 * 1024 - 32:
-                if rv:
+                    cmdline = " ".join(args[0:3] + args[begin:i])
-                    break
+                    # print("objs=", i - begin, ", length=", len(cmdline))
+                    rv = mySubProcess(cmdline, env)
+                    if rv:
+                        break
+                    begin = i
+                    length = lead + 1 + len(args[i])
+            if not rv:
+                cmdline = " ".join(args[0:3] + args[begin:])
+                # print("objs=", len(args) - begin, ", length=", len(cmdline))
+                rv = mySubProcess(cmdline, env)
         else:
-            rv = mySubProcess(cmdline, env)
+            rv = mySubProcess(args, env)
-
         return rv
 
     env["SPAWN"] = mySpawn