From 6d1073d8671ee525c332b08764b23861d83a7bc6 Mon Sep 17 00:00:00 2001 From: Zhehang Ding Date: Wed, 31 Aug 2022 19:05:58 -0700 Subject: [PATCH] Basis constructor: row vectors -> column vectors https://github.com/godotengine/godot-proposals/issues/5295 --- include/godot_cpp/variant/basis.hpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/godot_cpp/variant/basis.hpp b/include/godot_cpp/variant/basis.hpp index e7c5eaf2..ffc9d736 100644 --- a/include/godot_cpp/variant/basis.hpp +++ b/include/godot_cpp/variant/basis.hpp @@ -258,10 +258,10 @@ public: Basis(const Vector3 &p_axis, real_t p_phi) { set_axis_angle(p_axis, p_phi); } Basis(const Vector3 &p_axis, real_t p_phi, const Vector3 &p_scale) { set_axis_angle_scale(p_axis, p_phi, p_scale); } - inline Basis(const Vector3 &row0, const Vector3 &row1, const Vector3 &row2) { - elements[0] = row0; - elements[1] = row1; - elements[2] = row2; + inline Basis(const Vector3 &p_x, const Vector3 &p_y, const Vector3 &p_z) { + set_axis(0, p_x); + set_axis(1, p_y); + set_axis(2, p_z); } inline Basis() {}