Sara.Sync
/
godot-cpp
mirror of https://github.com/godotengine/godot-cpp
0
1
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1592 from dsnopek/4.3-revert-unexpose-is-instance-valid 

[4.3] Revert "Unexpose `UtilityFunctions::is_instance_valid()`"
pull/1041/head
David Snopek 2024-09-23 10:46:45 -05:00 committed by GitHub
parent e298f430b5 17ca325aeb
commit 1cce4d15ab
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
binding_generator.py
View File

@ -2166,12 +2166,6 @@ def generate_utility_functions(api, output_dir):
header.append("public:") header.append("public:")
for function in api["utility_functions"]: for function in api["utility_functions"]:
if function["name"] == "is_instance_valid":
# The `is_instance_valid()` function doesn't work as developers expect, and unless used very
# carefully will cause crashes. Instead, developers should use `ObjectDB::get_instance()`
# with object ids to ensure that an instance is still valid.
continue
vararg = "is_vararg" in function and function["is_vararg"] vararg = "is_vararg" in function and function["is_vararg"]
function_signature = "\t" function_signature = "\t"
@ -2206,9 +2200,6 @@ def generate_utility_functions(api, output_dir):
source.append("") source.append("")
for function in api["utility_functions"]: for function in api["utility_functions"]:
if function["name"] == "is_instance_valid":
continue
vararg = "is_vararg" in function and function["is_vararg"] vararg = "is_vararg" in function and function["is_vararg"]
function_signature = make_signature("UtilityFunctions", function) function_signature = make_signature("UtilityFunctions", function)